Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add clarification on birthtime #5479

Closed
wants to merge 1 commit into from
Closed

doc: add clarification on birthtime #5479

wants to merge 1 commit into from

Conversation

kthelgason
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

N/A

Description of change

This PR adds a small clarification to the docs on fs.Stat regarding the birthtime field.
The issue was raised in #2222.

@kthelgason kthelgason mentioned this pull request Feb 28, 2016
Closed
@mscdex mscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 28, 2016
@jasnell
Copy link
Member

jasnell commented Mar 2, 2016

LGTM

claudiorodriguez pushed a commit that referenced this pull request Mar 14, 2016
@kthelgason @claudiorodriguez
doc: add clarification on birthtime in fs stat
995a33b 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
@claudiorodriguez
Copy link
Contributor

Landed in 995a33b
Hope you don't mind I added a longer commit message to put the change in context

@kthelgason
Copy link
Contributor Author

Thanks @claudiorodriguez for landing and for clarifying the commit message.

@kthelgason kthelgason deleted the doc-fs-birthtime-clarify branch March 14, 2016 10:23
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@kthelgason @evanlucas
doc: add clarification on birthtime in fs stat
c678b52 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@kthelgason @rvagg
doc: add clarification on birthtime in fs stat
f3e9daa 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@kthelgason
doc: add clarification on birthtime in fs stat
a6fea63 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@kthelgason
doc: add clarification on birthtime in fs stat
ee98a3e 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@kthelgason
doc: add clarification on birthtime in fs stat
1afab6a 
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).

Fixes: #2222
PR-URL: #5479
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kthelgason @jasnell @claudiorodriguez @mscdex @MylesBorins